Remove unnecessary useEffect

Author: JunichiSugiura

packages/utils/src/context/tokens.tsx

@@ -96,17 +96,16 @@ export function TokensProvider({
 
     const initialTokens = tokens.reduce<Record<string, ERC20>>(
       (acc, token) => {
-        const normalizedAddress = getChecksumAddress(address);
         const contract = new ERC20Contract({
-          address: normalizedAddress,
+          address: token.address,
           provider,
         });
 
         return {
           ...acc,
-          [normalizedAddress]: {
+          [contract.address]: {
             ...token,
-            address: normalizedAddress,
+            address: contract.address,
             contract,
           }
         };
@@ -166,7 +165,6 @@ export function TokensProvider({
   const addresses = useMemo(() => Object.keys(tokens), [tokens]);
 
   const {
-    data: priceData,
     isLoading: isPriceLoading,
     error: priceError,
   } = usePriceByAddressesQuery(
@@ -176,28 +174,27 @@ export function TokensProvider({
     {
       refetchInterval,
       enabled: addresses.length > 0,
+      onSuccess: (data) => {
+        if (!data?.priceByAddresses) return;
+
+        setTokens((tokens) => {
+          data.priceByAddresses.forEach((price, index) => {
+            const address = addresses[index];
+            if (tokens[address]) {
+              tokens[address].price = price;
+            }
+          });
+          return tokens;
+        });
+      }
     },
   );
 
-  useEffect(() => {
-    if (priceData?.priceByAddresses) {
-      setTokens((prevTokens) => {
-        const newTokens = { ...prevTokens };
-        priceData.priceByAddresses.forEach((price, index) => {
-          const address = addresses[index];
-          if (newTokens[address]) {
-            newTokens[address].price = price;
-          }
-        });
-        return newTokens;
-      });
-    }
-  }, [priceData?.priceByAddresses, addresses]);
-
   const register = useCallback(
     async (address: string) => {
       if (!provider || tokens[getChecksumAddress(address)]) return;
 
+      const newTokens = { ...tokens };
       const contract = new ERC20Contract({
         address,
         provider,
@@ -207,15 +204,13 @@ export function TokensProvider({
         const balance = await contract.balanceOf(address);
         await contract.init();
         const metadata = contract.metadata();
+        newTokens[metadata.address] = {
+          ...metadata,
+          contract,
+          balance,
+        };
 
-        setTokens(tokens => ({
-          ...tokens,
-          [metadata.address]: {
-            ...metadata,
-            contract,
-            balance,
-          }
-        }));
+        setTokens(newTokens);
       } catch (error) {
         console.error(`Failed to load token ${address}:`, error);
       }

packages/utils/src/erc20.ts

@@ -25,7 +25,7 @@ export const STRK_CONTRACT_ADDRESS = getChecksumAddress(
 );
 
 export class ERC20Contract {
-  private address: string;
+  address: string;
   private provider: Provider;
 
   private name?: string;
@@ -66,7 +66,7 @@ export class ERC20Contract {
     }
 
     return {
-      address: getChecksumAddress(this.address),
+      address: this.address,
       name: this.name,
       symbol: this.symbol,
       decimals: this.decimals,