Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mark search as disabled for now #42

Closed
zkamvar opened this issue Jun 9, 2022 · 0 comments · Fixed by #44
Closed

mark search as disabled for now #42

zkamvar opened this issue Jun 9, 2022 · 0 comments · Fixed by #44

Comments

@zkamvar
Copy link
Contributor

zkamvar commented Jun 9, 2022

I thought I opened an issue to add functionality to the search button, but it turns out that I only generated a commit that begins the process with a note about what I found:

While Bootstrap 5 may have search enabled through their forms, it turns
out that it's difficult for me to find documentation for this specific
task. Moreover, the pkgdown searchbar never had a button associated with
the search... and for good reason: the search is dynamic; it does not
bring you to a page with your search results; it gives you the search
results as a dropdown menu, so you go to your result by clicking
"enter". It makes sense! I think we can provide a blank page for search
results, but we will need to test out the accessibility for sure.

The steps for me to resolve this are:

Originally posted by @zkamvar in carpentries/workbench#8 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant