Skip to content

Commit 3079f59

Browse files
authored
Merge pull request #116 from carpentries/fix-font-sizes
[bug fix] use rem units for callouts
2 parents 3e7db76 + 7b83b84 commit 3079f59

File tree

6 files changed

+21
-12
lines changed

6 files changed

+21
-12
lines changed

DESCRIPTION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
Package: varnish
22
Title: Front-end for The Carpentries Lesson Template
3-
Version: 1.0.0
3+
Version: 1.0.1
44
Authors@R: c(
55
person(given = "Zhian N.",
66
family = "Kamvar",

NEWS.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,12 @@
1+
# varnish 1.0.1 (2023-12-14)
2+
3+
## BUG FIX
4+
5+
* Font sizes for headings of overview box, callouts, and accordions now use
6+
relative units instead of pixels. This will cause a slight change in the
7+
appearance of these headings, but they will be more consistent as the size of
8+
the window changes.
9+
110
# varnish 1.0.0 (2023-12-13)
211

312
## MAJOR VERSION NOTE

inst/pkgdown/assets/assets/styles.css

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

inst/pkgdown/assets/assets/styles.css.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

source/stylesheets/callouts.scss

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,8 @@
2525

2626
.callout-title {
2727
position: relative;
28-
font-size: 18px;
29-
line-height: 24px;
28+
font-size: 1.25rem;
29+
line-height: 1.75rem;
3030
text-transform: uppercase;
3131
letter-spacing: 0.1em;
3232
margin: 0px 0px 25px 0px;
@@ -41,8 +41,8 @@
4141

4242
.callout li {
4343
margin-left: 0px;
44-
margin-top:10px;
45-
margin-bottom:20px;
44+
margin-top: 10px;
45+
margin-bottom: 20px;
4646
}
4747

4848
.callout-inner {
@@ -141,7 +141,7 @@
141141
font-family: Mulish;
142142
font-style: normal;
143143
font-weight: normal;
144-
font-size: 16px;
144+
font-size: 1.2rem;
145145
&:first-of-type .accordion-button {
146146
border-radius: 0;
147147
}
@@ -154,7 +154,7 @@
154154
font-family: Mulish;
155155
font-style: normal;
156156
font-weight: normal;
157-
font-size: 16px;
157+
font-size: 1.2rem;
158158
}
159159
.accordion-body {
160160
padding-left: 35px;
@@ -198,7 +198,7 @@
198198
}
199199
&, h3 {
200200
font-family: Mulish;
201-
font-size: 16px;
201+
font-size: 1.2rem;
202202
font-style: normal;
203203
font-weight: normal;
204204
text-transform: uppercase;

source/stylesheets/overview.scss

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
border: none;
77
height: 53px;
88
padding-top: 7px;
9-
font-size: calc(18px + 0.3vw);
9+
font-size: min(1.5rem, calc(1.25rem + 0.2vw));
1010
letter-spacing: 0.1em;
1111
font-weight: 400;
1212
}
@@ -39,7 +39,7 @@
3939
text-decoration-thickness: 1px;
4040
text-underline-offset: 25px;
4141
margin-bottom: 50px;
42-
font-size: min(25px, calc(22px + 0.2vw));
42+
font-size: min(1.5rem, calc(1.25rem + 0.25vw));
4343
font-weight: 600;
4444
line-height: 1.5rem;
4545
}

0 commit comments

Comments
 (0)