Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search not working #301

Closed
drmowinckels opened this issue Jun 22, 2022 · 1 comment
Closed

search not working #301

drmowinckels opened this issue Jun 22, 2022 · 1 comment
Labels
duplicate This issue or pull request already exists enhancement New feature or request

Comments

@drmowinckels
Copy link

The search feature doesnt seem to be working (I'm on chrome).
I cant get my cursor to land in the search field or get to typing anything.

I've tried both on locally rendered pages and GHA rendered pages.

@zkamvar zkamvar added duplicate This issue or pull request already exists enhancement New feature or request labels Jun 22, 2022
@zkamvar
Copy link
Contributor

zkamvar commented Jun 22, 2022

Thank you for bringing this up!

I've disabled the search purposefully in varnish 0.1.15 because I need to take some time to implement a proper solution that is accessible.

I'm going to close this in favour of carpentries/workbench#8, which has more details about why the search has been disabled.

(note: github only gives me two choices of closing: "completed" or "not planned", I want to emphasize that this IS planned, but the Workbench Beta phase is the current priority, which will certainly become easier to handle in the next couple of months)

@zkamvar zkamvar closed this as not planned Won't fix, can't repro, duplicate, stale Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants