Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image vs container #40

Closed
gajowi opened this issue Nov 24, 2020 · 2 comments
Closed

image vs container #40

gajowi opened this issue Nov 24, 2020 · 2 comments

Comments

@gajowi
Copy link

gajowi commented Nov 24, 2020

I've just read through the training (nice!) and have some comments and could potentially contribute. I'll start with a general description of a specific issue.

The use of the terms image and container could be more precise and consistent. I think the accepted/defined usage is that the image is the static artefact and the container is a running instance (which started as/from a particular image). This may link with Section on Layers

Also, the description of 'prune' and images left behind by exited containers is relevant. The container has an additional runtime layer for any filesystem changes made on-the-fly.

@aturner-epcc
Copy link
Contributor

Thanks for taking the time to look through and make comments @gajowi . I agree that we certainly want to be consistent with the terms and if you have contributions that could improve this, they would be most welcome. Alternatively, if you have spotted things that can be fixed and do not have the time to issue your own PR, then please feel free to point out anything in particular you spotted and we can get the improvements in.

There is definitely scope for improvement and more precision in the descriptions of particular operations (such as prune) and the descriptions of layers (see also #6) and I think some diagrams could also go a long way to helping introduce concepts around layers.

@sstevens2
Copy link
Contributor

Glad to hear you are interested in the lesson. If you have time for PRs or individual issues on things you note that need to be fixed that would be great! Contributions welcome!

This issue seems to be the same as #20 and #6 so I'm going to close it but please feel free to add additional comments in those issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants