-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Product thumbnail not showing properly #3
Comments
Image that is not showing is cart image just change To This
and do npm install or ng update if your using angular cli as global |
The project has been upgraded to Angular 5. I couldn't replicate this issue in this new version. Can you please try again and double check if the issue still remains? I'm happy to reopen the ticket should you still have trouble with this. |
I'm experiencing the same issue with the scrollbars in the product thumbnails like in the image above. However, the shopping cart icon is showing. I'm new to Angular as of 2 weeks ago so, everything is fresh to me. I'm running: Angular: 5.2.1. |
Hey @tiedyejedi thanks for the report. Mind sharing a screenshot of how it looks like on your end? I'm on Mac so I can't easily replicate the behaviour. Thanks! |
I did notice this warning in Visual Studio Code: Your global Angular CLI version (1.7.3) is greater than your local Never seen that before and I probably just didn't see it yesterday when I |
Update: removing this style fixes it: position: relative; in the .info and .wrapper classes of the product-thumbnail.component.sass file. So, my wrapper is now: and deleted the .info one as the position was the only thing in it. The best seller tag is removed, but I don't want that anyways. In fact, I'll be removing a lot more features. I don't need a search or order by. Not sure if it's possible, but making it more modular would help, IMO. That is, if it's even possible. I do like this shopping cart. Very well done! I do hope I can get it to work in my app, but at least I got a demo working on my server, so we'll see. |
Hey @tiedyejedi thanks for the follow up! Glad you figured it out. Yeah, the project isn't well organized actually, sorry about that. It was really not meant to be, I built it super quick and shoot the code here :D thanks again for the feedback, I'll use this to fix the scrollable thing. |
No problem about the organization. I like figuring things out. However, I just noticed my "fix" breaks the view details aspect of it, which is critical, but maybe something I can work around. |
I wonder, what if you try setting |
Product thumbnails are looking weird in my development server. View Details and Cart Option are not showing properly within the thumbnail.
Image Link : http://imgur.com/a/tTjcB
Using the latest angular/cli. Below is my package.json =>
package.json
package,json.txt
angular-cli.json
{
"project": {
"version": "1.0.0-beta.15",
"name": "angular2-store"
},
"apps": [{
"root": "src",
"outDir": "dist",
"assets": "assets",
"index": "index.html",
"main": "main.ts",
"test": "test.ts",
"tsconfig": "tsconfig.json",
"prefix": "app",
"mobile": false,
"styles": [
"styles.sass"
],
"scripts": [],
}],
"addons": [],
"packages": [],
"e2e": {
"protractor": {
"config": "./protractor.conf.js"
}
},
"test": {
"karma": {
"config": "./karma.conf.js"
}
},
"defaults": {
"styleExt": "sass",
"prefixInterfaces": false
}
}
Looking forward to your help. Other than this issue, the site looks amazing !
The text was updated successfully, but these errors were encountered: