New maintained fork

[andig]

@carlos22 I wanted to point you to https://github.com/andig/carddav2fb where I've created a fork of jensmaus about 6 18 months ago. The codebase has been entirely rewritten and some features added, e.g. ability to maintain quickdial and vanity numbers or pretty-printing phone numbers.

If interested I'd be happy accept PRs and act as "official" fork.

Cheers,
Andreas

[jens-maus]

@andig Thanks for your hard work. However, IMHO it would be better if you would simply submit your changes as a PR for @carlos22 to be integrated rather than having yet-another fork of carddav2fb. In fact, as @carlos22 integrated my changes recently I will also close my fork anytime soon.

[andig]

I would be happy if @carlos22 wants to look at the fork. However, it has been entirely rewritten: curl replaced by guzzle, parser replaced by library (and in-sourced again due to missing feature). Lots of grown (not to say spaghetti) code rewritten. So there won't be an easy merge and I'm not sure if it would be worth it.

I've added and closed a PR at #35 to give an impression.

Happy to wait for @carlos22 feedback and take it from there.

[carlos22]

Looks pretty good. 👍
Will test it soon.
I sure can integrate the changes (if it works well, but i assume it does) and I can give you write access to the repo if you want. The other possibility is to create an github organization for the repo.

[carlos22]

How should we proceed? I we might create a organisation and rename this repo to carddav2fb-legacy? We might add a small migration guide?

[andig]

/cc @blacksenator

[carlos22]

It might be better to merge the changes and branch the current master to legacy. This way we don't loose the stars and stuff.

[andig]

As for upgrade instructions we‘d need ro compare how the two have diverged. I really have no idea about this repo‘s functionality.