web: Fix Power Select auto-choosing bug #2040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I run this locally, it fixes the problem where the prepaid card chooser in the merchant creation workflow looks like it’s not opening but is really selecting the first card and closing. Thanks to @johanrd for documenting and @Aierie for finding: cibernox/ember-power-select#1408
|
This does move the dropdown down but I think it’s worth it!
|
|
This fixes one part of the issue, I think another part is the dropdown taking up space and pushing itself under the cursor as it scrolls. Wondering if we should not allow the dropdown to take up space in that way. |
|
This selection is done in a single click as the dropdown expanding pushes itself and the rest of the content up |
Aierie
approved these changes
Sep 3, 2021
burieberry
approved these changes
Sep 3, 2021
|
ya further revisions are still possible of course! |
delete-merged-branch
bot
deleted the
web/power-select-margin-to-fix-autoselect
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I run this locally, it fixes the problem where the prepaid
card chooser in the merchant creation workflow looks like
it’s not opening but is really selecting the first card and
closing.
Thanks to @johanrd for documenting and @Aierie for finding:
cibernox/ember-power-select#1408