-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP rough implementation of anchoring and inferred duration for parallel timelines #173
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickschot
force-pushed
the
anchoring-filling
branch
2 times, most recently
from
January 20, 2023 15:14
69acbf4
to
28311b2
Compare
nickschot
force-pushed
the
anchoring-filling
branch
from
January 27, 2023 14:39
277f2fe
to
4e3eb24
Compare
Example with video: Screen.Recording.2023-01-27.at.15.47.45.movtimeline: {
type: 'parallel',
animations: [
{
sprites: keptSprites,
properties: {
x: {},
y: {},
width: {},
height: {},
},
timing: {
behavior: new TweenBehavior(),
duration: 2000,
},
},
{
sprites: keptSprites,
properties: {
backgroundColor: {},
},
timing: {
behavior: new TweenBehavior(),
duration: 300,
anchor: 'center',
},
},
{
sprites: keptSprites,
properties: {
border: {},
},
timing: {
behavior: new TweenBehavior(),
anchor: 'fill',
},
},
],
} |
…es in their string
nickschot
force-pushed
the
anchoring-filling
branch
from
January 27, 2023 15:55
4e3eb24
to
a694485
Compare
backspace
approved these changes
Jan 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
]) | ||
); | ||
}); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I appreciate the clarity of these unit tests 🤩
Closing due to inactivity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
proof of concept/experimentation for #172
TODO:
duration
(be it implicit like a Spring, or explicit)fill
referencefill
overriding defined durations on MotionDefinitions if they're not the longest animation.Example with the current API
The
border
animation will take the duration of the Spring movement animation, since that is the longest animation. The background animation keeps it duration as it has a more specificanchor: center
set on it's MotionDefinition. It is centered to the middle of the duration of the entire parallel timeline.