Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ledger API testing #9

Closed
4 tasks done
mesudip opened this issue Jun 5, 2024 · 7 comments
Closed
4 tasks done

Ledger API testing #9

mesudip opened this issue Jun 5, 2024 · 7 comments
Assignees

Comments

@mesudip
Copy link

mesudip commented Jun 5, 2024

ToDos

  • Check existing ledger api tests, what is covered and what is not
  • Add tests of functionalities that are not covered.

Acceptance Criteria

  • Planning document listing new tests to add on top of existing tests
  • Report on the new tests and verification of the existing tests, and their correctness (PR merge remaining)
@mesudip
Copy link
Author

mesudip commented Jun 6, 2024

To be discussed with @nabinpkl on the details

@mesudip
Copy link
Author

mesudip commented Jun 6, 2024

  • Verification of existing tests using Cardano Ledger api - using cardano-cli
  • Constitution hash tests, cold, hotkey pair tests, same hashes can be generated and hashes can be verified - Already included
  • Authorization certification, Vote delegation certification, drep registration certifications tests - All attributes are checked on already included tests
  • Drep tests and user delegation tests via ledger - using cli - some dreps tests are added from our side too
  • Governance tests on interfaces exposed from cardano ledger api - tests using cli
  • View vote/governance actions files - view tests already included
  • Query governance, DrepState, committee state exposed from cardano ledger api - Query via cli already included
  • Automatic expiration for committee members check - Already included
  • Tests for info, update committee, constitution, no-confidence, withdrawal, update protocol params on cardano ledger level - - - - Validated using cli , some gov actions are limited on node 8.11
  • Terms check for Constitutional committee - Validated on node 8.9.2
  • Resignation check for committee member - Validated
  • Abstain and no-confidence check via ledger - using cli - validated
  • Governance action submission check - using cli - validated
  • Gov actions epoch boundaries check - using cli- validated - info not working
  • Protocol params updation check for each of the protocol params updated are being reflected - all ppparams have been checked and already included
  • Governance actions are in ordered - Not applicable as they are accepted as transaction are accepted no specific ordering
  • Duplicated committee members are avoided on the ledger level - Already included

@mesudip
Copy link
Author

mesudip commented Jun 7, 2024

Scope

Using cardano-cli (in cardano-node-tests) validate all the governance related actions and user scenarios.

ToDos Remaining

  • Use Always pass and Always Fail plutus script to register and retire drep
  • Verification of plutus Script for ada-holder delegation to drep
  • Consitution script (Skipped on 8.11 - Not allowed on bootstrap phase)
  • CC scripts (Skipped on 8.11 - Not allowed on bootstrap phase

@mesudip
Copy link
Author

mesudip commented Jun 18, 2024

To use drep scripts we need this PR merged to cluster lib: input-output-hk/cardano-clusterlib-py#243

PR for cardano-node-tests repo: IntersectMBO/cardano-node-tests#2444

@mesudip
Copy link
Author

mesudip commented Jun 18, 2024

@mesudip
Copy link
Author

mesudip commented Jul 1, 2024

@nabinpkl is this ready with cardano-node 8.12.0?

@nabinpkl
Copy link

nabinpkl commented Jul 8, 2024

Drep scripts tests using plutus has been added in the cardano-node-tests by intersect team.

IntersectMBO/cardano-node-tests#2464

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants