Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow labels to be read for combobox and hide labels but keep them accessible to screen reader #2918

Merged
merged 4 commits into from
Jun 12, 2024

Conversation

Akshat55
Copy link
Contributor

Accessibility improvement to combobox and dropdown.

Changelog

New

  • Can hide label for dropdown and combobox

Changed

  • Combobox label is now read by screen reader

@Akshat55 Akshat55 requested a review from a team as a code owner June 12, 2024 22:54
Copy link

netlify bot commented Jun 12, 2024

Deploy Preview for moonlit-truffle-7c2756 ready!

Name Link
🔨 Latest commit 204dc52
🔍 Latest deploy log https://app.netlify.com/sites/moonlit-truffle-7c2756/deploys/666a2b933628680008e8547d
😎 Deploy Preview https://deploy-preview-2918--moonlit-truffle-7c2756.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Akshat55 Akshat55 merged commit ab09b91 into carbon-design-system:v10 Jun 12, 2024
18 checks passed
@Akshat55 Akshat55 deleted the combobox-label-readaloud branch June 12, 2024 23:23
Copy link

🎉 This PR is included in version 4.75.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant