Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include ibm telemetry config file in published build #2865

Conversation

francinelucca
Copy link
Contributor

telemetry.yml file needs to be included in published package to be able to collect telemetry. This PR modifies the build script to include such file.

Changelog

Changed

  • Upgrade @ibm/telemetry-js to version 1.5.0
  • Modify build script to copy telemetry.yml to dist folder
  • Replace @carbon/telemetry with @ibm/telemetry-js in ng-package.json's allowedNonPeerDependencies
  • Replace @carbon/telemetry with @ibm/telemetry-js in src/package.json. Update postinstall script.

@francinelucca francinelucca requested a review from a team as a code owner April 22, 2024 15:58
Copy link

netlify bot commented Apr 22, 2024

Deploy Preview for carbon-components-angular ready!

Name Link
🔨 Latest commit 85bbb0a
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-angular/deploys/6626894097f2ef00087e780a
😎 Deploy Preview https://deploy-preview-2865--carbon-components-angular.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Akshat55 Akshat55 merged commit 42dd2af into carbon-design-system:master Apr 22, 2024
13 checks passed
Copy link

🎉 This PR is included in version 5.24.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants