You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are three main things that need to be fixed:
The sortable header cells should not be intractable and should not have the skeleton loading state applied.
There are a few things going wrong here, 1. is that the buttons that handle sorting in the header need to be hidden and replaced with the static headers and, 2. the .cds--data-table--sort class needs to be removed from the table to avoid the extra padding in the header.
The body cell should have the skeleton loading state applied
Looking at the @carbon/styles package source, it expects there to be a span inside the body row cell when the table is in the skeleton state. The fix here might be as easy as adding <span *ngIf="skeleton"></span> to the end of the table-data.component.ts template.
Expandable rows need to have their expand button hidden.
The skeleton state isn't applied to the peripheral components like the title and toolbar.
There may be other issues but these are the main ones I'm seeing.
Possible solutions
Apply the fixes to the current data table component
Follow the same path as the react team and add a dedicated skeleton table component and remove it from the base datatable
a. This would align the library with the core react library and simplify the logic in the base data table (a lot of *ngIf="!skeleton" scattered around the code at the moment that could be removed) but might be considered a worst developer experience.
I'm happy to create a PR for either options, wdyt?
The text was updated successfully, but these errors were encountered:
The issues
Expectation:
See the react storybook for reference: https://react.carbondesignsystem.com/?path=/story/components-datatable-skeleton--skeleton&globals=theme:white
Actual:
See the angular storybook https://angular.carbondesignsystem.com/?path=/story/components-table--skeleton
There are three main things that need to be fixed:
There may be other issues but these are the main ones I'm seeing.
Possible solutions
a. This would align the library with the core react library and simplify the logic in the base data table (a lot of
*ngIf="!skeleton"
scattered around the code at the moment that could be removed) but might be considered a worst developer experience.I'm happy to create a PR for either options, wdyt?
The text was updated successfully, but these errors were encountered: