-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crystalball budgets too many rows per chunk when system has a lot of memory #55
Comments
very strange, so far it's worked beautifully for me (except for the first few percent of the time, but then it stabilizes) |
I remember mentioning it a couple of days ago to @sjperkins that the progress bar went from 99% to 1% suddenly, as @sjperkins explained this, it is a matter of estimating progress than actually computing it? |
@KshitijT was this at the start, or somewhere in between? At the start it's acceptable |
I checked this yesterday on codex-africanus master branch and it seemed to work. I think the problem here is that there are only 4 chunks of work # 2023-04-05 10:52:22 | INFO | budget:get_budget | nr sources = 7830
# 2023-04-05 10:52:22 | INFO | budget:get_budget | nr rows = 626913
...
# 2023-04-05 10:52:22 | INFO | budget:get_budget | sources per chunk = 4249 (auto settings)
# 2023-04-05 10:52:22 | INFO | budget:get_budget | rows per chunk = 424942 (auto settings) so the progress bar doesn't get to make good estimates (based on historical data). If you increase the chunking on row, do things improve? |
I agree, it shouldn't be saying 100% done from the start though. |
This was somewhere inbetween. |
|
Description
Predicting from a wsclean source list. The progress logged was 100% from the start, to when I terminated the run.
What I Did
Ran crystalball through caracal
https://github.com/caracal-pipeline/caracal/blob/751769ce6d6f14651c03e5988d71eef032e88d84/caracal/workers/crosscal_worker.py#L587
I terminated after 3 hours.
The text was updated successfully, but these errors were encountered: