Skip to content

Enable Next.js lint rules for skin-database and skin-museum-og #1326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
captbaritone merged 1 commit into from
Nov 28, 2025
Merged

Enable Next.js lint rules for skin-database and skin-museum-og #1326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/skin-database/.eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
module.exports = {
extends: ["plugin:@typescript-eslint/recommended"],
extends: [
"plugin:@typescript-eslint/recommended",
"plugin:@next/next/recommended",
],
rules: {
// Disable rules that conflict with the project's style
"@typescript-eslint/no-var-requires": "off",
Expand All @@ -12,6 +15,8 @@ module.exports = {
"no-shadow": "off",
// camelcase has too many violations (333) to fix now
camelcase: "off",
// This codebase uses <img> for OG images and legacy code
"@next/next/no-img-element": "off",
},
ignorePatterns: ["dist/**"],
};
1 change: 1 addition & 0 deletions packages/skin-database/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@
"@types/node-fetch": "^2.5.7",
"@typescript-eslint/eslint-plugin": "^8.36.0",
"@typescript-eslint/parser": "^8.36.0",
"eslint-config-next": "14",
"grats": "0.0.0-main-e655d1ae",
"typescript": "^5.6.2"
},
Expand Down
7 changes: 7 additions & 0 deletions packages/skin-museum-og/.eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
module.exports = {
extends: ["next/core-web-vitals"],
rules: {
// This package generates OG images using <img>
"@next/next/no-img-element": "off",
},
};
1 change: 1 addition & 0 deletions packages/skin-museum-og/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
"react-dom": "18.2.0"
},
"devDependencies": {
"eslint-config-next": "14",
"vercel": "^28.4.17"
}
}
Loading