Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing volume redis in Nextcloud #1019

Merged
merged 1 commit into from
Nov 18, 2023
Merged

Fix missing volume redis in Nextcloud #1019

merged 1 commit into from
Nov 18, 2023

Conversation

Vdauphin
Copy link
Contributor

@Vdauphin Vdauphin commented Nov 14, 2023

First of all, thank you for your contribution! 😄

Please note that this repo is mostly for popular apps with thousands of stars and tens of thousands of downloads. If you'd like to add a less popular app, you can always create your own 3rd party repo and add your app there.

☑️ Self Check before Merge

  • I have tested the template using the method described in README.md thoroughly
  • I have ensured that I put as much default values as possible (except passwords) to ensure minimum effort required for end users to get started.
  • I have ensured that I am not using the "latest" tag as this tag is dynamically changing and might break the one-click app. Use a fixed version.
  • I have made sure that instructions.start and instructions.end are clear and self-explanatory.
  • Icon is added as a png file to the logos directory.
  • I've executed the checks if necessary by running npm ci && npm run validate_apps && npm run formatter
  • I will take responsibility addressing any issues that arises as a result of this PR (maintaining this app).

@@ -17,6 +17,8 @@ services:
documentation: Taken from https://github.com/nextcloud/docker/blob/master/.examples/docker-compose/with-nginx-proxy/mariadb-cron-redis/apache/docker-compose.yml
image: redis:$$cap_redis_version
restart: always
volumes:
- $$cap_appname-redis-data:/data
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

redis doesn't have any persistent data by default unless the start command is changed.

Why is this volume needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know exactly but when I checked the volume of the redis docker (with docker inspect -f '{{ .Mounts }}'), it has shown a volume with random number (https://stackoverflow.com/questions/62649302/docker-run-volume-keeps-creating-random-volumes-and-not-using-the-one-specifie)
Also it seems to have a volume /data define in docker file here: https://github.com/docker-library/redis/blob/master/7.2/alpine3.18/Dockerfile#L103
The CapRover app has a volume also https://github.com/caprover/one-click-apps/blob/master/public/v4/apps/redis.yml#L5

@githubsaturn githubsaturn merged commit 1627bff into caprover:master Nov 18, 2023
1 check passed
@Vdauphin Vdauphin deleted the nc_fixredis_volume branch November 18, 2023 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants