Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the readibility and simplify _generate_uncorrelated_column_data function in TabularGenerator class #328

Open
ksneab7 opened this issue Aug 8, 2023 · 1 comment
Assignees
Labels
contribution_day enhancement New feature or request

Comments

@ksneab7
Copy link
Contributor

ksneab7 commented Aug 8, 2023

Is your feature request related to a problem? Please describe.
_generate_uncorrelated_column_data is functionally correct but has a lot of conditional statements that have big code blocks that have a good amount of repeated code. We should limit these to a function (Specifically reading in the statistics portion of the profile report we are reading in)

Describe the outcome you'd like:
I would like the code to have these if conditionals either call a singular function or limit the repetitive code within the function that exists in its current state

@taylorfturner
Copy link
Contributor

Basically DRY-er code -- good call out. This is the link to the function in the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution_day enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants