Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dask Max Version Tag #1121

Open
taylorfturner opened this issue Mar 22, 2024 · 3 comments
Open

Dask Max Version Tag #1121

taylorfturner opened this issue Mar 22, 2024 · 3 comments
Assignees
Labels
Bug Something isn't working

Comments

@taylorfturner
Copy link
Contributor

General Information:

  • OS: Linux
  • Python version: 3.9.18
  • Library version: 0.10.9

Describe the bug:
Dask change a couple things subsequent to Feb 9, 2024. We have had to put a max pin on Dask version to 2024.2.0. Not pinning outputs the following error in the unit testing suite

____ ERROR collecting dataprofiler/tests/validators/test_base_validators.py ____
/opt/hostedtoolcache/Python/3.10.13/x64/lib/python3.10/site-packages/dask/dataframe/__init__.py:22: in _dask_expr_enabled
    import dask_expr  # noqa: F401
E   ModuleNotFoundError: No module named 'dask_expr'

During handling of the above exception, another exception occurred:
dataprofiler/tests/validators/test_base_validators.py:4: in <module>
    from dask import dataframe as dd
/opt/hostedtoolcache/Python/3.10.13/x64/lib/python3.10/site-packages/dask/dataframe/__init__.py:87: in <module>
    if _dask_expr_enabled():
/opt/hostedtoolcache/Python/3.10.13/x64/lib/python3.10/site-packages/dask/dataframe/__init__.py:24: in _dask_expr_enabled
    raise ValueError("Must install dask-expr to activate query planning.")
E   ValueError: Must install dask-expr to activate query planning.

To Reproduce:
Don't pin max on dask in requirements-test.txt file

Expected behavior:
No errors -- ideally with no max version pin on dask installation

@taylorfturner taylorfturner added the Bug Something isn't working label Mar 22, 2024
@taylorfturner
Copy link
Contributor Author

#1120 fixing but ultimately will need to resolve to not have late vintage version pins

@gliptak
Copy link
Contributor

gliptak commented Jun 9, 2024

#1090

@gliptak
Copy link
Contributor

gliptak commented Jun 13, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants