Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate tests to native node test runner #357

Closed
daogrady opened this issue Oct 14, 2024 · 1 comment · Fixed by #481
Closed

Migrate tests to native node test runner #357

daogrady opened this issue Oct 14, 2024 · 1 comment · Fixed by #481
Labels
improvement keepalive Will not be closed by Stale bot

Comments

@daogrady
Copy link
Contributor

Node has introduced their own test runner in v18.
Using that instead of Jest would save us one dependency.

Copy link
Contributor

This issue has not been updated in a while. If it is still relevant, please comment on it to keep it open. The issue will be closed soon if it remains inactive.

@github-actions github-actions bot added the stale label Nov 13, 2024
@daogrady daogrady added keepalive Will not be closed by Stale bot and removed stale labels Nov 13, 2024
daogrady added a commit that referenced this issue Feb 5, 2025
Fixes #357

Replaces Jest with the [NodeJS test
runner](https://nodejs.org/api/test.html).
As noted
[here](https://nodejs.org/en/learn/test-runner/using-test-runner#using-nodejss-test-runner),
the globs needed to properly use the runner with our multiple suites
require at least Node21. As we currently test with Node18 as lower
bound, we have to wrap the call to the test scripts in a [bit of
code](https://github.com/cap-js/cds-typer/blob/chore/nodejs-testrunner/test/testRunner.js)
to do the glob logic for us.

As an aside, this PR also changes the nomenclature of all tests to match
the common practice of using _should..._ instead of the former Title
Casing.

---------

Co-authored-by: Jörg Mann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement keepalive Will not be closed by Stale bot
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant