From 3a928f757ed4719c2ceba75d2af104e067e2f152 Mon Sep 17 00:00:00 2001
From: Bob den Os <bob.den.os@sap.com>
Date: Tue, 15 Oct 2024 08:57:13 +0200
Subject: [PATCH 1/2] Add efficient API INSERT tests

---
 test/compliance/INSERT.test.js | 61 ++++++++++++++++++++++++++++++++--
 1 file changed, 58 insertions(+), 3 deletions(-)

diff --git a/test/compliance/INSERT.test.js b/test/compliance/INSERT.test.js
index 5895bc524..d6a57651b 100644
--- a/test/compliance/INSERT.test.js
+++ b/test/compliance/INSERT.test.js
@@ -1,6 +1,12 @@
-require('../cds')
+const cds = require('../cds')
+
+const { Readable } = require('stream')
 
 describe('INSERT', () => {
+  const { data, expect } = cds.test(__dirname + '/resources')
+  data.autoIsolation(true)
+  data.autoReset()
+
   describe('into', () => {
     test.skip('missing', () => {
       throw new Error('not supported')
@@ -8,8 +14,57 @@ describe('INSERT', () => {
   })
 
   describe('entries', () => {
-    test.skip('missing', () => {
-      throw new Error('not supported')
+    const genCount = 100
+    const gen = function* () {
+      for (let i = 0; i < genCount; i++)
+        yield { uuid: cds.utils.uuid() }
+    }
+
+    test('array', async () => {
+      const { uuid } = cds.entities('basic.literals')
+
+      await INSERT([...gen()]).into(uuid)
+
+      const result = await SELECT.from(uuid)
+      expect(result.length).to.eq(genCount)
+    })
+
+    test('iterator', async () => {
+      const { uuid } = cds.entities('basic.literals')
+
+      await INSERT(gen()).into(uuid)
+
+      const result = await SELECT.from(uuid)
+      expect(result.length).to.eq(genCount)
+    })
+
+    test('Readable (Object Mode)', async () => {
+      const { uuid } = cds.entities('basic.literals')
+
+      await INSERT(Readable.from(gen())).into(uuid)
+
+      const result = await SELECT.from(uuid)
+      expect(result.length).to.eq(genCount)
+    })
+
+    test('Readable (Raw Mode)', async () => {
+      const { uuid } = cds.entities('basic.literals')
+
+      const raw = function* (src) {
+        yield '['
+        let sep = ''
+        for (const obj of src) {
+          yield sep
+          yield JSON.stringify(obj)
+          sep = ','
+        }
+        yield ']'
+      }
+
+      await INSERT(Readable.from(raw(gen()), { objectMode: false })).into(uuid)
+
+      const result = await SELECT.from(uuid)
+      expect(result.length).to.eq(genCount)
     })
   })
 

From 20bba0edefc84755f211536a285e235c01b5f899 Mon Sep 17 00:00:00 2001
From: Bob den Os <bob.den.os@sap.com>
Date: Tue, 15 Oct 2024 09:39:42 +0200
Subject: [PATCH 2/2] Add Iterator and ObjectMode Readable checks

---
 db-service/lib/cqn2sql.js | 30 ++++++++++++++++--------------
 1 file changed, 16 insertions(+), 14 deletions(-)

diff --git a/db-service/lib/cqn2sql.js b/db-service/lib/cqn2sql.js
index e99c613eb..6bb866a08 100644
--- a/db-service/lib/cqn2sql.js
+++ b/db-service/lib/cqn2sql.js
@@ -520,13 +520,14 @@ class CQN2SQLRenderer {
     // Include this.values for placeholders
     /** @type {unknown[][]} */
     this.entries = []
-    if (INSERT.entries[0] instanceof Readable) {
+    if (INSERT.entries[0] instanceof Readable && !INSERT.entries[0].readableObjectMode) {
       INSERT.entries[0].type = 'json'
       this.entries = [[...this.values, INSERT.entries[0]]]
     } else {
-      const stream = Readable.from(this.INSERT_entries_stream(INSERT.entries), { objectMode: false })
+      const entries = INSERT.entries[0] instanceof Iterator || INSERT.entries[0] instanceof Readable ? INSERT.entries[0] : INSERT.entries
+      const stream = Readable.from(this.INSERT_entries_stream(entries), { objectMode: false })
       stream.type = 'json'
-      stream._raw = INSERT.entries
+      stream._raw = entries
       this.entries = [[...this.values, stream]]
     }
 
@@ -536,14 +537,11 @@ class CQN2SQLRenderer {
 
   async *INSERT_entries_stream(entries, binaryEncoding = 'base64') {
     const elements = this.cqn.target?.elements || {}
-    const transformBase64 = binaryEncoding === 'base64'
-      ? a => a
-      : a => a != null ? Buffer.from(a, 'base64').toString(binaryEncoding) : a
     const bufferLimit = 65536 // 1 << 16
     let buffer = '['
 
     let sep = ''
-    for (const row of entries) {
+    for await (const row of entries) {
       buffer += `${sep}{`
       if (!sep) sep = ','
 
@@ -570,9 +568,13 @@ class CQN2SQLRenderer {
           buffer += '"'
         } else {
           if (elements[key]?.type in BINARY_TYPES) {
-            val = transformBase64(val)
-          }
+            buffer += `${keyJSON}${val != null
+              ? `"${Buffer.from(val, 'base64').toString(binaryEncoding)}"`
+              : 'null'
+              }`
+          } else {
           buffer += `${keyJSON}${JSON.stringify(val)}`
+          }
         }
       }
       buffer += '}'
@@ -588,9 +590,6 @@ class CQN2SQLRenderer {
 
   async *INSERT_rows_stream(entries, binaryEncoding = 'base64') {
     const elements = this.cqn.target?.elements || {}
-    const transformBase64 = binaryEncoding === 'base64'
-      ? a => a
-      : a => a != null ? Buffer.from(a, 'base64').toString(binaryEncoding) : a
     const bufferLimit = 65536 // 1 << 16
     let buffer = '['
 
@@ -618,9 +617,12 @@ class CQN2SQLRenderer {
           buffer += '"'
         } else {
           if (elements[this.columns[key]]?.type in BINARY_TYPES) {
-            val = transformBase64(val)
+            buffer += val != null
+              ? `"${Buffer.from(val, 'base64').toString(binaryEncoding)}"`
+              : 'null'
+          } else {
+            buffer += `${sepsub}${val == null ? 'null' : JSON.stringify(val)}`
           }
-          buffer += `${sepsub}${val === undefined ? 'null' : JSON.stringify(val)}`
         }
 
         if (!sepsub) sepsub = ','