Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sqlite] Pass options to constructor of bettersqlite3 #920

Open
aschmidt93 opened this issue Nov 28, 2024 · 0 comments · May be fixed by #921
Open

[sqlite] Pass options to constructor of bettersqlite3 #920

aschmidt93 opened this issue Nov 28, 2024 · 0 comments · May be fixed by #921

Comments

@aschmidt93
Copy link

The constructor of bettersqlite3 is currently called without any options https://github.com/WiseLibs/better-sqlite3/blob/master/docs/api.md#new-databasepath-options in SQLiteService.js:

const dbc = new sqlite(database);

Users should be able to specify options in cds.requires.db.sqlite which are then passed to the constructor of bettersqlite3:

const dbc = new sqlite(database, this.options.sqlite);
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant