Skip to content

Commit 4f36fb7

Browse files
Fix failing unit test.
1 parent 8e5dab2 commit 4f36fb7

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

canopen/emcy.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ def on_emcy(self, can_id, data, timestamp):
4545
else:
4646
entry = EmcyError(code, register, data, timestamp)
4747
self.log.append(entry)
48+
self.active.append(entry)
4849

4950

5051
class EmcyError(Exception):

test/test_emcy.py

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,12 @@
55
class TestEmcy(unittest.TestCase):
66

77
def test_emcy_list(self):
8-
emcy_node = emcy.EmcyNode()
8+
emcy_node = emcy.EmcyConsumer()
99
emcy_node.on_emcy(0x81, b'\x01\x20\x02\x00\x01\x02\x03\x04', 1473418396.0)
1010
emcy_node.on_emcy(0x81, b'\x10\x90\x01\x00\x01\x02\x03\x04', 1473418397.0)
11-
emcy_node.on_emcy(0x81, b'\x00\x00\x00\x00\x00\x00\x00\x00', 1473418397.0)
1211

13-
self.assertEqual(len(emcy_node.log), 3)
12+
self.assertEqual(len(emcy_node.log), 2)
13+
self.assertEqual(len(emcy_node.active), 2)
1414

1515
error = emcy_node.log[0]
1616
self.assertIsInstance(error, emcy.EmcyError)
@@ -19,15 +19,18 @@ def test_emcy_list(self):
1919
self.assertEqual(error.register, 0x02)
2020
self.assertEqual(error.data, b'\x00\x01\x02\x03\x04')
2121
self.assertAlmostEqual(error.timestamp, 1473418396.0)
22+
self.assertEqual(emcy_node.active[0], error)
2223

2324
error = emcy_node.log[1]
2425
self.assertEqual(error.code, 0x9010)
2526
self.assertEqual(error.register, 0x01)
2627
self.assertEqual(error.data, b'\x00\x01\x02\x03\x04')
2728
self.assertAlmostEqual(error.timestamp, 1473418397.0)
29+
self.assertEqual(emcy_node.active[1], error)
2830

29-
error = emcy_node.log[2]
30-
self.assertIsInstance(error, emcy.ErrorReset)
31+
emcy_node.on_emcy(0x81, b'\x00\x00\x00\x00\x00\x00\x00\x00', 1473418397.0)
32+
self.assertEqual(len(emcy_node.log), 2)
33+
self.assertEqual(len(emcy_node.active), 0)
3134

3235
def test_str(self):
3336
error = emcy.EmcyError(0x2001, 0x02, b'\x00\x01\x02\x03\x04', 1473418396.0)

0 commit comments

Comments
 (0)