Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noble 24.04 minor improvements #272

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

hector-cao
Copy link
Collaborator

This PR comes with 2 commits:

  • output the qemu command to a script
    this will allow users to run manually the guest after the test
    this capability is useful for debugging purposes
    for example, the user can run the guest manually by doing:
$ sudo /tmp/tdxtest-default-hk8u6mf3/run.sh

hk8u6mf3 is random and may vary for each test

  • right now, we use proc.terminate() to send SIGTERM to qemu process
    this tends to corrupt the rootfs
    this will prevent us from running the guest again with this rootfs
    try to stop the VM (shutdown) properly first and terminate() it
    later if necessary

this will allow users to run manually the guest after the test
this capability is useful for debugging purposes
right now, we use proc.terminate() to send SIGTERM to qemu process
this tends to corrupt the rootfs
this will prevent us from running the guest again with this rootfs
try to stop the VM (shutdown) properly first and terminate() it
later if necessary
@hector-cao hector-cao requested a review from a team November 15, 2024 09:37
Copy link
Collaborator

@frenchwr frenchwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Only thing I'm wondering is if you need or want to document how to use the qemu troubleshooting script, but I leave it up to you, so not a blocker.

@hector-cao
Copy link
Collaborator Author

LGTM. Only thing I'm wondering is if you need or want to document how to use the qemu troubleshooting script, but I leave it up to you, so not a blocker.

Yes, agree but i have the feeling that for now, i m the only one who runs the tests. but definitely if someone starts to use them, i can enrich the documentation

@hector-cao hector-cao merged commit 198e71a into noble-24.04 Nov 15, 2024
2 checks passed
@hector-cao hector-cao deleted the noble-24.04-minor-improvements branch November 21, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants