Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kexec/Kdump Tests #237

Merged
merged 7 commits into from
Oct 1, 2024
Merged

Kexec/Kdump Tests #237

merged 7 commits into from
Oct 1, 2024

Conversation

spmcmillan
Copy link
Collaborator

https://warthogs.atlassian.net/browse/PEK-852

Adding kexec/kdump tests for the host. This requires the host to be rebooted effectively multiple times. So, this was written as a shell script that can be used, eventually, in testflinger, or in a runner.

@frenchwr
Copy link
Collaborator

@spmcmillan Just making sure I understand before looking at the code - are these the first tests that need to be run remotely over ssh to the TDX host? If so do they need some sort of special treatment or category that is separate from existing test_host* tests (since the existing tests need to be run directly from the host while these new ones need to be run from a machine with ssh access to the host)? I guess eventually maybe all the tests could be run this way by invoking commands remotely over ssh?

@spmcmillan
Copy link
Collaborator Author

@spmcmillan Just making sure I understand before looking at the code - are these the first tests that need to be run remotely over ssh to the TDX host? If so do they need some sort of special treatment or category that is separate from existing test_host* tests (since the existing tests need to be run directly from the host while these new ones need to be run from a machine with ssh access to the host)? I guess eventually maybe all the tests could be run this way by invoking commands remotely over ssh?

Yes, these are probably the only tests that will need to be run remotely as they require the system to reboot or crash whenever they are invoked. I'm not sure the ideal place to put these. They won't be picked up by the pytests so they are already isolated and won't be included with the checkbox tests either. They are very special case and I can see them running on testflinger on the agent. I thought this was an ok to put them because they have the ".sh" extension. But, if you have other ideas please suggest them!

@frenchwr
Copy link
Collaborator

They won't be picked up by the pytests so they are already isolated and won't be included with the checkbox tests either.

Ah ok - I was thinking they would but I guess with the .sh extension tox/pytest will not pick them up. 👍

tests/tests/test_host_kdump.sh Outdated Show resolved Hide resolved
tests/tests/test_host_kdump.sh Outdated Show resolved Hide resolved
tests/tests/test_host_kdump.sh Outdated Show resolved Hide resolved
tests/tests/test_host_kdump.sh Outdated Show resolved Hide resolved
tests/tests/test_host_kdump.sh Outdated Show resolved Hide resolved
@spmcmillan spmcmillan requested a review from frenchwr October 1, 2024 12:49
tests/tests/test_host_kdump.sh Outdated Show resolved Hide resolved
tests/tests/test_host_kdump.sh Outdated Show resolved Hide resolved
@spmcmillan spmcmillan requested a review from hector-cao October 1, 2024 15:41
tests/tests/test_host_kdump.sh Show resolved Hide resolved
tests/tests/test_host_kdump.sh Outdated Show resolved Hide resolved
…ine when the system went down instead of a timeout
@spmcmillan spmcmillan requested a review from frenchwr October 1, 2024 18:41
Copy link
Collaborator

@frenchwr frenchwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I like the changes.

@spmcmillan spmcmillan dismissed hector-cao’s stale review October 1, 2024 19:07

I've already resolved it

@spmcmillan spmcmillan merged commit 9851592 into noble-24.04 Oct 1, 2024
1 check passed
@hector-cao hector-cao deleted the pek852_kexec_kdump_host_tests branch October 11, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants