Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select: form validation with required attribute #1045

Open
jw-can opened this issue Feb 20, 2024 · 1 comment · May be fixed by #1110
Open

Select: form validation with required attribute #1045

jw-can opened this issue Feb 20, 2024 · 1 comment · May be fixed by #1110
Labels
Bug 🐛 Something isn't working P3 Triaged Issue has been reviewed as part of legacy backlog grooming (project P3). Triaged: v4 Triaged, to be implemented as part of Vanilla v4

Comments

@jw-can
Copy link

jw-can commented Feb 20, 2024

When setting the required attribute on <Select>, this attribute is not passed to the <select> element. This results in client-side form validation ignoring the required select field.

See also: https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/required
@kaiweike kaiweike linked a pull request Jul 30, 2024 that will close this issue
Open
@bartaz bartaz added Bug 🐛 Something isn't working P3 Triaged Issue has been reviewed as part of legacy backlog grooming (project P3). Triaged: v4 Triaged, to be implemented as part of Vanilla v4 labels Sep 30, 2024
@bartaz
Copy link
Member

bartaz commented Sep 30, 2024

Triage: should be relatively low effort to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug 🐛 Something isn't working P3 Triaged Issue has been reviewed as part of legacy backlog grooming (project P3). Triaged: v4 Triaged, to be implemented as part of Vanilla v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(Select): Add support for required attribute kaiweike/react-components
2 participants
@bartaz @jw-can