Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spelling error in instance snapshot deletion trigger name #13862

Open
markylaing opened this issue Aug 2, 2024 · 2 comments · May be fixed by #14043
Open

Spelling error in instance snapshot deletion trigger name #13862

markylaing opened this issue Aug 2, 2024 · 2 comments · May be fixed by #14043
Assignees
@kadinsayani @markylaing
Labels
Bug Confirmed to be a bug
Milestone
lxd-6.2

Comments

@markylaing
Copy link
Contributor

See #13846 (comment)_

We'll need a DB patch to fix this.
@markylaing markylaing self-assigned this Aug 2, 2024
@markylaing markylaing mentioned this issue Aug 2, 2024
Merged
@tomponline tomponline added the Bug Confirmed to be a bug label Aug 2, 2024
@tomponline tomponline added this to the lxd-6.2 milestone Aug 2, 2024
@tomponline
Copy link
Member

@markylaing can @kadinsayani help with this?

@markylaing
Copy link
Contributor Author

markylaing commented Sep 4, 2024 •
edited
Loading

@markylaing can @kadinsayani help with this?

Yes that would be great. For this, we need a patch (see lxd/patches.go) to be applied at stage patchPreLoadClusterConfig that deletes the on_instance_snaphot_delete trigger (note spelling error) if it exists. The deletion trigger for the instance_snapshot entity type needs to be updated to have the correct spelling.

Note that we only need the patch to run once, ideally on the leader.

@kadinsayani kadinsayani linked a pull request Sep 4, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kadinsayani kadinsayani

@markylaing markylaing

Labels
Bug Confirmed to be a bug
Projects
None yet
Milestone
lxd-6.2
Development

Successfully merging a pull request may close this issue.

Patches: Fix spelling error in instance snapshot deletion trigger name kadinsayani/lxd
3 participants
@tomponline @kadinsayani @markylaing