Use *.svc.cluster.local wildcard as the CN
#49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
CN is deprecated, but the TLS charmlib requires it
canonical/tls-certificates-interface#369
Currently we set it as the app name, but that is invalid because the CN must be derived from the SANs DNS.
Let's Encrypt complains (via Lego charm):
We cannot use
socket.getfqdn()because it's too long.https://community.letsencrypt.org/t/simplifying-issuance-for-very-long-domain-names/207924
Solution
Use a (silly) wildcard,
*.svc.cluster.local.Very different circumstances, but google practices the same.

Context
Mimir, Loki, Tempo charms do not have an analogue to traefik's
external_hostnameconfig option, meaning they currently cannot obtain a cert from e.g. Let's Encrypt. Only internal CA. So the*.localshould be safe for now.If we keep using self-signed-certificates, then this PR is not needed, because that "CA" is very permissive. But for a more strict internal CA this is probably a good change.
Testing Instructions
Upgrade Notes