Skip to content

Commit fb56bc5

Browse files
committed
Address PR feedbacks
1 parent aee14c7 commit fb56bc5

12 files changed

+14
-113
lines changed

Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ KYUUBI_ARTIFACT=$(ROCK_NAME)-kyuubi_$(SPARK_VERSION)_$(PLATFORM).tar
7575
# eg, charmed-spark_gpu_3.4.2_amd64.rock
7676
ROCK_FILE_GPU=$(ROCK_NAME_GPU)_$(SPARK_VERSION)_$(PLATFORM).rock
7777

78-
# The filename of the final artifact built for Spark image
78+
# The filename of the final artifact built for Spark GPU image
7979
# eg, charmed-spark-gpu_3.4.2_amd64.tar
8080
SPARK_GPU_ARTIFACT=$(ROCK_NAME_GPU)_$(SPARK_VERSION)_$(PLATFORM).tar
8181

@@ -243,7 +243,7 @@ $(ROCK_FILE_GPU): images/charmed-spark-gpu/rockcraft.yaml $(wildcard images/char
243243
rock-gpu: $(ROCK_FILE_GPU)
244244

245245

246-
# Recipe that builds Spark image and exports it to a tarfile in the current directory
246+
# Recipe that builds Spark GPU image and exports it to a tarfile in the current directory
247247
$(SPARK_GPU_MARKER): $(ROCK_FILE_GPU) images/charmed-spark-gpu/Dockerfile
248248
rockcraft.skopeo --insecure-policy \
249249
copy \

images/charmed-spark-gpu/bin-spark

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
../charmed-spark/bin

images/charmed-spark-gpu/bin/history-server.sh

Lines changed: 0 additions & 6 deletions
This file was deleted.

images/charmed-spark-gpu/bin/spark-client.pyspark

Lines changed: 0 additions & 3 deletions
This file was deleted.

images/charmed-spark-gpu/bin/spark-client.service-account-registry

Lines changed: 0 additions & 3 deletions
This file was deleted.

images/charmed-spark-gpu/bin/spark-client.spark-shell

Lines changed: 0 additions & 3 deletions
This file was deleted.

images/charmed-spark-gpu/bin/spark-client.spark-sql

Lines changed: 0 additions & 3 deletions
This file was deleted.

images/charmed-spark-gpu/bin/spark-client.spark-submit

Lines changed: 0 additions & 3 deletions
This file was deleted.

images/charmed-spark-gpu/bin/sparkd.sh

Lines changed: 0 additions & 30 deletions
This file was deleted.
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
spark.kubernetes.container.image=ghcr.io/canonical/charmed-spark:3.4-22.04
1+
spark.kubernetes.container.image=ghcr.io/canonical/charmed-spark-gpu:3.4-22.04

0 commit comments

Comments
 (0)