Fix bug preventing Refs being serialized properly #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imaustink
force-pushed
the
360-fix-ref-serialization
branch
from
9c9ef6c to
6a30fda
Compare
imaustink
commented
Oct 11, 2017
| Ref.prototype.serialize = function() { | ||
| return this[idProp]; | ||
| Ref.prototype.serialize = Ref.prototype[canSymbol.for("can.serialize")] = function() { | ||
| return canReflect.serialize(this[idProp], CIDMap); |
There was a problem hiding this comment.
Is there a good reason to provide a Map here? Seems to me like it would only be good for circular reference, which shouldn't happen here.
justinbmeyer
approved these changes
Jun 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #360