Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move connection options to bottom-most link in prototype chain #327

Open
nlundquist opened this issue Jul 3, 2017 · 1 comment
Open
Assignees

Comments

@nlundquist
Copy link
Contributor

Likely implemented as part of #304.

Currently can-connect connection options are stored in the top-most object in the connection prototype chain. This is somewhat unintuitive since options are subject to being hidden by properties on behaviors since they are lower on the prototype chain. Relatedly the options object would be a good place to store connection-specific overrides of behavior methods but this currently can't be done because the behavior will always be lower on the proto chain than the options.

@justinbmeyer
Copy link
Contributor

This might be worth changing for 5.0. options should overwrite everything ... possibly be both "on top" and "on bottom" at the same time...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants