We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scroll position restoration is buggy in different browsers.
Here’s the code. I think most of it is unnecessary. https://github.com/canjs/bit-docs-html-canjs/blob/master/static/canjs.js#L334-L362
Below are a few common cases that we should get right. It’d be nice to have tests around these, similar to what we have for the sidebar:
bit-docs-html-canjs/sidebar/test.js
Lines 302 to 334 in 9eefe6a
It’s completely broken in Firefox:
When the user clicks on an in-page navigation link, the header for that section should be visible under the sticky header.
It lands on the wrong position in multiple browsers; here’s Firefox:
After refreshing, the user should end up where they scrolled, not back at the old section. I think this is broken in all browsers.
The text was updated successfully, but these errors were encountered:
cherifGsoul
Successfully merging a pull request may close this issue.
Scroll position restoration is buggy in different browsers.
Here’s the code. I think most of it is unnecessary. https://github.com/canjs/bit-docs-html-canjs/blob/master/static/canjs.js#L334-L362
Below are a few common cases that we should get right. It’d be nice to have tests around these, similar to what we have for the sidebar:
bit-docs-html-canjs/sidebar/test.js
Lines 302 to 334 in 9eefe6a
1. Scroll down and refresh the page
It’s completely broken in Firefox:
2. Click on a specific section
When the user clicks on an in-page navigation link, the header for that section should be visible under the sticky header.
3. Refresh after going to a specific section
It lands on the wrong position in multiple browsers; here’s Firefox:
4. Refresh after going to a specific section and scrolling
After refreshing, the user should end up where they scrolled, not back at the old section. I think this is broken in all browsers.
The text was updated successfully, but these errors were encountered: