Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An in-range update of can-define is breaking the build 🚨 #566

Open
greenkeeper bot opened this issue Aug 1, 2019 · 2 comments
Open

An in-range update of can-define is breaking the build 🚨 #566

greenkeeper bot opened this issue Aug 1, 2019 · 2 comments

Comments

@greenkeeper
Copy link
Contributor

greenkeeper bot commented Aug 1, 2019

The dependency can-define was updated from 2.7.20 to 2.7.21.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

can-define is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details
  • continuous-integration/travis-ci/push: The Travis CI build failed (Details).

Commits

The new version differs by 3 commits.

  • d083eb9 2.7.21
  • 00ff114 Merge pull request #470 from canjs/doc-change--core-legacy
  • 4780879 change can-core to can-legacy for docs

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Aug 1, 2019

After pinning to 2.7.20 your tests are still failing. The reported issue might not affect your project. These imprecisions are caused by inconsistent test results.

@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Aug 9, 2019

  • The dependency can-define was updated from 2.7.21 to 2.8.0.

Your tests are passing again with this update. Explicitly upgrade to this version 🚀

Release Notes for Add support for value and oldValue in events

Dispatched events now have a value that represents the new value, and an oldValue for the old value.

defineMap.listenTo("prop", (ev) => {
  console.log("New value", ev.value, "Old value", ev.oldValue);
});
Commits

The new version differs by 5 commits.

See the full diff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

0 participants