Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scrolling doesn't work #555

Open
justinbmeyer opened this issue Jun 29, 2019 · 1 comment
Open

scrolling doesn't work #555

justinbmeyer opened this issue Jun 29, 2019 · 1 comment

Comments

@justinbmeyer
Copy link
Contributor

on: https://canjs.com/doc/guides/data-managing-sessions.html

Recording

Notice that this is not keeping the "midpoint" of the page visible like it was doing before and doing on bitovi/academy.

@chasenlehara
Copy link
Member

I’ve looked into this a bit. I initially thought it was because it has a 1ms debounce on the scroll listener, but it looks like bit-docs-html-toc has the same thing.

The biggest difference is bit-docs-html-canjs only changes the scroll position if the active item isn’t visible, so it doesn’t do any unnecessary scrolling, then it relies on the browser to animate the scroll. Maybe that’s why the behavior is different?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants