Fix bug preventing loading indicator from showing #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@imaustink Could you please add a gif for slow connections? I wasn’t seeing the bar at all with a slow 3G connection, as depicted in #391 |
imaustink
force-pushed
the
391-fix-loading-indicator
branch
from
d9d077f to
03e34c5
Compare
|
@chasenlehara oops! My bad! I've added that. |
imaustink
force-pushed
the
391-fix-loading-indicator
branch
2 times, most recently
from
cbe189c to
37bf811
Compare
|
@chasenlehara I made the changes you recommended. |
chasenlehara
requested changes
Sep 1, 2017
static/loading-bar.js
Outdated
| @@ -1,5 +1,7 @@ | |||
| var starting = 5; | |||
There was a problem hiding this comment.
I would move this inline since it’s not reused anywhere.
static/loading-bar.js
Outdated
| clearTimeout(this.timer); | ||
| this.timer = null; | ||
| } | ||
| this.meter.css('width', progress || starting + '%'); |
There was a problem hiding this comment.
Order of operations here matters. 😊 To make this more clear, I would follow the progress = progress || 5 pattern.
static/loading-bar.js
Outdated
| this.meter.css('width', progress + '%'); | ||
| if(progress === 100){ | ||
| this.timer = setTimeout(function(){ | ||
| console.log('hide'); |
There was a problem hiding this comment.
face palm I need a linter rule for console.log 😝
imaustink
force-pushed
the
391-fix-loading-indicator
branch
2 times, most recently
from
b6de5f3 to
ab8284c
Compare
|
@chasenlehara good point! I updated the PR. |
Since we have a CSS animation on the width of the bar, and on a fast network the progress event usaully only fires once (at 100%), hiding the loading indicator eminently after calling `.end()` would not allow the animation to complete before the bar hidden. This PR adds a timer to wait for the CSS animation before hiding the bar. closes #392
imaustink
force-pushed
the
391-fix-loading-indicator
branch
from
ab8284c to
2e51408
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug preventing loading indicator from showing
Since we have a CSS animation on the width of the bar, and on a fast network the progress event usaully only fires once (at 100%), hiding the loading indicator eminently after calling
.end()would not allow the animation to complete before the bar hidden.This PR adds a timer to wait for the CSS animation before hiding the bar.
closes #392
Desktop:
Mobile:
Slow 3G Mobile: