Upgrade strophe

[benlangfeld]

No description provided.

[benlangfeld]

This appears to be broken due to strophe/strophejs#105 introducing AMD in a way that's not backwards-compatible with non-AMD apps like Candy. I'm not sure if that can be fixed in Strophe, or if Candy needs to move to something like require.js. Thoughts @jcbrand / @mweibel?

[mweibel]

require.js/AMD is not going to happen, it doesn't bring any value (actually quite the opposite, TBH) and becomes soon obsolete due to ES6 (this is my own personal opinion).
Why strophe now moves to AMD, I don't know.. Why it doesn't work I don't know either, what is the error you get?

[benlangfeld]

@mweibel You can see the error in the Travis CI test run. The strange thing is that an app appears functional regardless.

[mweibel]

@benlangfeld sorry, late reply. Tested it locally as well and it seems to work also. Wondering why it fails.. could it be that we'd need to add Strophe to the loader settings of tests/intern.js?

[benlangfeld]

I tried that and it didn't make any difference.

[mweibel]

Sorry, I have some issues with running the tests locally.. that's why it takes so long...

[mweibel]

@benlangfeld the test run on saucelabs, can you give me the URL? I didn't find it on https://saucelabs.com/u/candy-chat-ci somehow :(

[benlangfeld]

https://saucelabs.com/users/candy-chat-ci/tests