Restore Tomcat 10 Failing Tests for 7.22

[psavidis]

Acceptance Criteria (Required on creation)

The integration-tests-engine-jakarta tests incompatible with Tomcat 10, Arquillian and weld-servlet-shaded are restored and pass the CI for camunda-bpm-platform 7.22 .

Here is the commit that demonstrates the exclusion.

Hints

File: qa/integration-tests-engine-jakarta/pom.xml
Profile: tomcat
Maven-plugin: maven-surefire-plugin
Prerequisite: The issue with Tomcat10,Arquillian and weld-servlet-shaded is fixed.
Action Needed: Delete the TODO and all the exclusions of the Tomcat 10 failing tests after.

Analytical Test Classes List

• CallActivityContextSwitchTest
• TestMultipleClasspathRoots
• TestResourceName
• TestWarDeploymentDeployChangedOnlyWithJarAsLib
• TestWarDeploymentWithDiagram
• TestWarDeploymentWithoutDiagram
• TestWarDeploymentWithoutProcessDefinitions
• TestWarDeploymentWithoutProcessesXml
• CdiBeanCallActivityResolutionTest
• CdiBeanCaseTaskResolutionTest
• CallActivityContextSwitchTest
• FailingJobBoundaryTimerWithDelegateVariablesTest
• SignalEventCatchBoundaryWithVariablesTest
• TimerRecalculationTest
• CdiProcessApplicationEventSupportTest

Links

• Parent Issue: Support Tomcat 10 #2471

Breakdown

Pull Requests

Beta Give feedback

1. test(tomcat10): restore engine integration tests #4491
   ci:all-as +1
   
2. chore(tomcat-runtime): Fix webapp-IT-tomcat-10-h2 failing tests #4498
   ci:tomcat ci:webapp-integration +2
   
3. https://github.com/camunda/camunda-bpm-platform-ee/pull/963
4. docs(content/update): Add Weld Issue Workaround Note camunda-docs-manual#1664
   +0
   

[tasso94]

Hi @psavidis,

I was able to restore most of the integration tests for Tomcat 10. The fix is to add the WELD library to the Tomcat 10 server libs folder.

Please have a look at the linked pull request. You might also want to look at how to fix the two remaining tests, CallActivityContextSwitchTest and CdiBeanCallActivityResolutionTest. I guess the fix looks similar to what I did for the other tests.

We should document this in the migration guide/patch level guide under which circumstances users cannot embed the WELD library in their WARs and instead need to add it to the server libs folder.

Can you please drive this topic forward (including backports for 7.21) in my absence?

I also informed the customer about this in the following support case:

• https://jira.camunda.com/browse/SUPPORT-19605

Can you please keep an eye on them in case there are follow-up questions?

Best,
Tassilo

[psavidis]

Progress Update

Test: CdiBeanCallActivityResolutionTest
Approaches that didn't work:

• Replace addContainerSpecificResourcesForNonPa with addContainerSpecificResourcesForNonPaEmbedCdiLib

  • Unknown property used in expression: ${conditionalFlowBean.shouldTakeFlow()}. Cause: Cannot resolve identifier 'conditionalFlowBean'

• Inline the war creation as done in other tests and add web-servlet-shaded to the libs folder

  • Code here
  • [ERROR] testResolveBeanInBpmnProcess(org.camunda.bpm.integrationtest.functional.cdi.CdiBeanCallActivityResolutionTest) Time elapsed: 0.165 s <<< ERROR! org.camunda.bpm.engine.ProcessEngineException: Error while evaluating expression: ${processVariableBean.newValue}. Cause: class org.camunda.bpm.engine.ProcessEngine$ProcessEngineServices$1435462394$Proxy$_$$_WeldClientProxy cannot be cast to class org.jboss.weld.bean.proxy.ProxyObject (org.camunda.bpm.engine.ProcessEngine$ProcessEngineServices$1435462394$Proxy$_$$_WeldClientProxy is in unnamed module of loader java.net.URLClassLoader @4f063c0a; org.jboss.weld.bean.proxy.ProxyObject is in unnamed module of loader org.apache.catalina.loader.ParallelWebappClassLoader @7a88085a) at org.camunda.bpm.integrationtest.functional.cdi.CdiBeanCallActivityResolutionTest.testResolveBeanInBpmnProcess(CdiBeanCallActivityResolutionTest.java:111) Caused by: java.lang.ClassCastException: class org.camunda.bpm.engine.ProcessEngine$ProcessEngineServices$1435462394$Proxy$_$$_WeldClientProxy cannot be cast to class org.jboss.weld.bean.proxy.ProxyObject (org.camunda.bpm.engine.ProcessEngine$ProcessEngineServices$1435462394$Proxy$_$$_WeldClientProxy is in unnamed module of loader java.net.URLClassLoader @4f063c0a; org.jboss.weld.bean.proxy.ProxyObject is in unnamed module of loader org.apache.catalina.loader.ParallelWebappClassLoader @7a88085a) at org.camunda.bpm.integrationtest.functional.cdi.CdiBeanCallActivityResolutionTest.testResolveBeanInBpmnProcess(CdiBeanCallActivityResolutionTest.java:111)

Test: CallActivityContextSwitchTest
Approaches that didn't work:

• Inline the war creation as done in other tests and add weld-servlet-shaded to the libs folder
  • Code here
  • [ERROR] testMainASyncCalledASync(org.camunda.bpm.integrationtest.functional.context.CallActivityContextSwitchTest) Time elapsed: 0.347 s <<< ERROR! org.camunda.bpm.engine.ProcessEngineException: Error while evaluating expression: ${delegateBefore}. Cause: class org.camunda.bpm.engine.ProcessEngine$ProcessEngineServices$886788125$Proxy$_$$_WeldClientProxy cannot be cast to class org.jboss.weld.bean.proxy.ProxyObject (org.camunda.bpm.engine.ProcessEngine$ProcessEngineServices$886788125$Proxy$_$$_WeldClientProxy is in unnamed module of loader java.net.URLClassLoader @4f063c0a; org.jboss.weld.bean.proxy.ProxyObject is in unnamed module of loader org.apache.catalina.loader.ParallelWebappClassLoader @184cdb9b) at org.camunda.bpm.integrationtest.functional.context.CallActivityContextSwitchTest.testMainASyncCalledASync(CallActivityContextSwitchTest.java:284) Caused by: java.lang.ClassCastException: class org.camunda.bpm.engine.ProcessEngine$ProcessEngineServices$886788125$Proxy$_$$_WeldClientProxy cannot be cast to class org.jboss.weld.bean.proxy.ProxyObject (org.camunda.bpm.engine.ProcessEngine$ProcessEngineServices$886788125$Proxy$_$$_WeldClientProxy is in unnamed module of loader java.net.URLClassLoader @4f063c0a; org.jboss.weld.bean.proxy.ProxyObject is in unnamed module of loader org.apache.catalina.loader.ParallelWebappClassLoader @184cdb9b) at org.camunda.bpm.integrationtest.functional.context.CallActivityContextSwitchTest.testMainASyncCalledASync(CallActivityContextSwitchTest.java:284)

[psavidis]

Update

Test: CdiBeanCallActivityResolutionTest

Debugging revealed that when adding weld-servlet-shaded using the addContainerSpecificResourcesEmbedCdiLib method in cases where there is a process deployment with a call activity that calls a bean (ConditionalFlowBean),

a) the bean is created
b) when the spin expression tries to call the ${conditionalFlowBean.shouldTakeFlow()}, the test testResolveBeanInBpmnProcessConditionalFlow fails.

The above looks related to the call activity setup.

[psavidis]

To avoid losing time, the fix is merged.
This ticket can remain open until the last 2 tests are either

a) accepted without a fix
b) a fix is found for them as well

[psavidis]

Added a message to migration guide + patch level section to notice users of the classloading issue workaround (PR)

Assigning to @danielkelemen for review.

PS: When the above is finalised and merged, will proceed with the backport.

[psavidis]

All test failures for CE/EE latest code are passing.

Opened up a new ticket for tracking the last 2 remaining tests that are not yet fixed CallActivityContextSwitchTest, CdiBeanCallActivityResolutionTest.

Closing this ticket.