Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify engine/pom.xml maven-shade-plugin plugin settings #4412

Open
1 task
venetrius opened this issue Jun 6, 2024 · 1 comment
Open
1 task

Simplify engine/pom.xml maven-shade-plugin plugin settings #4412

venetrius opened this issue Jun 6, 2024 · 1 comment
Assignees
Labels
type:task Issues that are a change to the project that is neither a feature nor a bug fix.

Comments

@venetrius
Copy link
Member

Acceptance Criteria (Required on creation)

in engine/pom.xml we exclude a long list of libraries when the goal is to only include camundajar.impl.com.google.gson.
We could replace the list with a easier to understand list. It would be also safer as we would not include any library by mistake.

          <artifactSet>
            <excludes>
              <exclude>org.camunda.bpm.model:*</exclude>
              <exclude>org.camunda.bpm.dmn:*</exclude>
              <exclude>org.camunda.bpm.juel:*</exclude>
              <exclude>org.camunda.commons:*</exclude>
              <exclude>org.camunda.connect:*</exclude>
              <exclude>org.camunda.feel:*</exclude>

              <exclude>org.springframework:*</exclude>
              <exclude>org.slf4j:*</exclude>
              <exclude>org.apache.commons:*</exclude>
              <exclude>com.sun.mail:*</exclude>
              <exclude>javax.activation:*</exclude>
              <exclude>org.mybatis:mybatis:*</exclude>
              <exclude>commons-logging:*</exclude>
              <exclude>joda-time:*</exclude>
              <exclude>org.apache.httpcomponents:httpclient</exclude>
              <exclude>org.apache.httpcomponents:httpcore</exclude>
              <exclude>commons-codec:commons-codec</exclude>
            </excludes>
          </artifactSet>

Hints

Links

Breakdown

Pull Requests

No tasks being tracked yet.

Dev2QA handover

  • Does this ticket need a QA test and the testing goals are not clear from the description? Add a Dev2QA handover comment
@venetrius venetrius added the type:task Issues that are a change to the project that is neither a feature nor a bug fix. label Jun 6, 2024
@venetrius venetrius self-assigned this Jun 6, 2024
@tasso94
Copy link
Member

tasso94 commented Jun 6, 2024

When I introduced the Maven shade plugin for the engine, the inclusion approach didn't work, possibly due to a bug in the plugin. This may have changed since then. 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:task Issues that are a change to the project that is neither a feature nor a bug fix.
Projects
None yet
Development

No branches or pull requests

2 participants