Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples should use different string values #31

Open
npepinpe opened this issue Dec 6, 2019 · 0 comments
Open

Examples should use different string values #31

npepinpe opened this issue Dec 6, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@npepinpe
Copy link
Contributor

npepinpe commented Dec 6, 2019

I recently helped a user through his use case with Kafka/Connect/Zeebe, and one of the hurdles he faced with the examples is we reuse the same strings everywhere, which for someone unaware might imply a connection between them. For example, the sink connector name is "pong", the message name is "pong", workflow name is "pong", etc. We should use different names to illustrate they have nothing related to each other (except in the places where they do!).

@npepinpe npepinpe added the enhancement New feature or request label Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant