add_xmlid should check that xmlid does not exist on another model

[guewen]

The add_xmlid method currently skips the creation of the xmlid if it already exists on a different record. It should fail instead.

anthem/anthem/lyrics/records.py

Lines 9 to 28 in 3dc8e39

	def add_xmlid(ctx, record, xmlid, noupdate=False):
	""" Add a XMLID on an existing record """
	try:
	ref_id, __, __ = ctx.env['ir.model.data'].xmlid_lookup(xmlid)
	except ValueError:
	pass # does not exist, we'll create a new one
	else:
	return ctx.env['ir.model.data'].browse(ref_id)
	if '.' in xmlid:
	module, name = xmlid.split('.')
	else:
	module = ''
	name = xmlid
	return ctx.env['ir.model.data'].create({
	'name': name,
	'module': module,
	'model': record._name,
	'res_id': record.id,
	'noupdate': noupdate,
	})