New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type information to builtins #11

Open

cameron-martin opened this issue Jan 31, 2024 · 1 comment

Owner

cameron-martin commented Jan 31, 2024

#8 added autocomplete to builtins but typed everything as any. We can do better than this since there's a bunch of type information in the protobuf.

Owner Author

cameron-martin commented Jan 31, 2024

It isn't that obvious to me how to construct non-primitive values of starlark::typing::Ty.

It looks like the only option is to use Ty::starlark_value, which would require generating instances of StarlarkValue from the protobuf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment