Skip to content

Conversation

@JINO-ROHIT
Copy link
Collaborator

im unaware if this works correctly but figured it might be a good idea to get early feedback -

  1. adds TaskStreamingChunkEvent
  2. adds asbtract method in callback
  3. extends workforce logger
  4. update single_agent_worker to handle streaming chunks via this task

@github-actions github-actions bot added the Review Required PR need to be reviewed label Nov 10, 2025
@JINO-ROHIT JINO-ROHIT self-assigned this Nov 10, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 10, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat-3379

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@fengju0213
Copy link
Collaborator

@JINO-ROHIT thanks for contribution!

Copy link
Collaborator

@fengju0213 fengju0213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this feature! The overall direction is correct, but there are some critical issues that need to be addressed before this can work properly.

chunk=chunk.msg.content,
chunk_index=chunk_index,
)
if (
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here assumes self.callback exists in SingleAgentWorker, but it doesn't. Workers have no way to access the callbacks registered in Workforce.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we need add a mechanism to propagate callbacks from Workforce to Worker instances.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the worker callback, I suggest implementing callback support at the BaseNode level, since all node types (both Worker and Workforce) could benefit from this change.
However, it might be good to get some feedback from @Wendong-Fan on this idea.

):
try:
await (
self.callback.log_task_streaming_chunk(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

log_task_streaming_chunk is defined as a synchronous method in WorkforceCallback

@JINO-ROHIT
Copy link
Collaborator Author

yeah thanks, i suppose we wait till wendong gives some comments then, ill also take some time to come up w alts,

@waleedalzarooni waleedalzarooni self-requested a review November 19, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Review Required PR need to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Add streaming chunk events to WorkforceCallback for real-time agent output monitoring

3 participants