-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[Docs] Added documentation for benchmarks #3340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@Tanuj-Taneja1 thanks for this pr! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Tanuj-Taneja1 thanks for your contribution!
|
Hi @fengju0213 |
thanks @Tanuj-Taneja1 , it's really a great suggestion, please feel free to open a new issue to isolate tests for changes unrelated to functional code (e.g., doc updates) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we also need to add this new doc to index.rst file, also let's use benchmark.md instead of Benchmark.md to align with other docs' naming
cc @fengju0213
| 3. `run()`: Execute benchmark and populate `self._results` | ||
| 4. Optional: Override `train`, `valid`, `test` properties | ||
|
|
||
| ## References |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems we missing the reference for BrowseComp Benchmark cc @fengju0213
Description
Fixes #3278
Checklist
Go over all the following points, and put an
xin all the boxes that apply.Fixes #issue-numberin the PR description (required)pyproject.tomlanduv lockIf you are unsure about any of these, don't hesitate to ask. We are here to help!