Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few minor issues #8

Open
LukasWallrich opened this issue Jan 17, 2023 · 3 comments
Open

A few minor issues #8

LukasWallrich opened this issue Jan 17, 2023 · 3 comments
Assignees

Comments

@LukasWallrich
Copy link
Contributor

When using dedup_refs, I encountered a few minor issues:

  • the returned tibble in unique is grouped, which can lead to issues in further analysis (e.g., when using summarise). Maybe better ungroup() it before returning?
  • the message Joining, by = "record_id" is shown in between your status updates - maybe specify by = in all join calls?

It would also be better practice to use message() rather than print() for the status updates - for example when one wants to use ASySD in a Rmd document where the status updates are not very helpful.

@LukasWallrich
Copy link
Contributor Author

Also, since you are giving such nice status updates, might it be worth including the number of duplications and potential duplicates? I imagine that that is something nearly every user will want to know right after running dedup_citations?

@kaitlynhair
Copy link
Member

All great suggestions! I have now fixed most of these issues. Haven't added the N potential duplicates message yet - might want to make some improvements to manual dedup functionality first.

@LukasWallrich
Copy link
Contributor Author

Copying two things here from a CiteSource issue:

  • Does this rename make sense? raw_citations$pages <- raw_citations$start_page? Should it not then be start_page-end_page?
  • Do we really want to reset record_ids? I would leave it up to the user to provide them if they want to, and just check if they are unique - i.e change raw_citations$record_id <- ""

@kaitlynhair kaitlynhair self-assigned this Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants