Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spell blast was drawn off-screen #582

Open
NQNStudios opened this issue Feb 8, 2025 · 2 comments · May be fixed by #587
Open

spell blast was drawn off-screen #582

NQNStudios opened this issue Feb 8, 2025 · 2 comments · May be fixed by #587
Labels
bug game Affects the game, as opposed to the editors

Comments

@NQNStudios
Copy link
Collaborator

In combat I saw a blast for Ice Bolt on one of my PCs get drawn out-of-bounds of the terrain window. For one thing, it seems like the camera should show the target of the spell? And for another, blasts shouldn't draw outside the border of the terrain window.

@NQNStudios NQNStudios added bug game Affects the game, as opposed to the editors labels Feb 8, 2025
@NQNStudios
Copy link
Collaborator Author

Oh, this is very much related to #97.

@NQNStudios
Copy link
Collaborator Author

I propose making the missile animation check for when the missile sprite goes out-of-bounds. When it does, it should move camera focus to the missile's target before continuing the animation (but also apply a clip_rect with the terrain window boundaries).

@NQNStudios NQNStudios linked a pull request Feb 9, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug game Affects the game, as opposed to the editors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant