Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncredited graphics/code contributions #469

Open
NQNStudios opened this issue Nov 16, 2024 · 17 comments
Open

Uncredited graphics/code contributions #469

NQNStudios opened this issue Nov 16, 2024 · 17 comments
Labels
meta Related to the build system or other things other than the code work Non coding related task

Comments

@NQNStudios
Copy link
Collaborator

NQNStudios commented Nov 16, 2024

So the following people are listed as repo contributors, but their usernames/names aren't in the credits from what I can tell:

A bunch more are in here: https://github.com/calref/cboe/blob/a725dc606a63fef3c9e61a68d4d41c827b7af48e/doc/game/Credits.html

If I pinged you with this, and you want your name/handle to be in the OpenBoE credits for programming, drop a comment with your name/handle!

@NQNStudios
Copy link
Collaborator Author

Also @CelticMinstrel I have a vague memory that you mentioned some people who made graphics are missing, too. Can you remember who? Or am I making that up?

@daerogami
Copy link
Contributor

Sure, Daerogami is fine. I can't recall if I provided any substantial contributions though it has been so long! 😅

@CelticMinstrel
Copy link
Member

CelticMinstrel commented Nov 19, 2024

@evan-erdos and @x-qq are already listed. I'm not 100% sure but I think @catphive is probably the one listed as Chokboyz. Missing from your list is *i (Stareye). I don't think he contributed a lot but I'm pretty sure there were a few bits I integrated from his fork (they probably have his name in the commit message).

Also @CelticMinstrel I have a vague memory that you mentioned some people who made graphics are missing, too. Can you remember who? Or am I making that up?

See here, though I'm not 100% sure if that's up-to-date.

@CelticMinstrel CelticMinstrel added meta Related to the build system or other things other than the code work Non coding related task labels Nov 19, 2024
@seisatsu
Copy link
Contributor

seisatsu commented Nov 19, 2024 via email

@NQNStudios
Copy link
Collaborator Author

See here, though I'm not 100% sure if that's up-to-date.

Everyone mentioned there is covered. 👍

@NQNStudios
Copy link
Collaborator Author

NQNStudios commented Nov 19, 2024

Here's another bunch of credits in the documentation that aren't mirrored in the ingame credits. Idk how I'll go about making these DRY--and didn't realize a further overhaul overhaul probably needs to add missing things to the credits in the documentation too. 😓

https://github.com/calref/cboe/blob/a725dc606a63fef3c9e61a68d4d41c827b7af48e/doc/game/Credits.html

^ Having JV credited as "Ayatollah of Rock-n-Rollah" seems like a pretty outdated joke. lol

@akien-mga
Copy link
Contributor

akien-mga commented Nov 19, 2024

Hi! My contributions were minor SCons improvements and compilation fixes for Linux. They were pretty minor changes, I don't think they warrant crediting me as a programming contributor. Thanks for asking though, I appreciate.

@catphive
Copy link
Member

My sole contribution was convincing people on the forums who were passing back and forth zip files to use version control. I think I created a google code repo (when that was a thing) back in 2009, and added CelticMinstrel. From that point on I have not contributed one line of code :)

@NQNStudios
Copy link
Collaborator Author

@catphive what you've just described is a massive contribution!

@catphive
Copy link
Member

If you want, you can say "Brendan Miller told people use version control" :) Again, I have no code contributions, except maybe checking in the contents of a zip file, and even that I'm kind of hazy on since it was so long ago.

@CelticMinstrel
Copy link
Member

CelticMinstrel commented Nov 20, 2024

Seems I was probably wrong about @catphive being Chokboyz then? I'm pretty sure I remember Chokboyz doing actual coding. Perhaps all his contributions occurred before version control? That also applies to Ormus, whose contributions were actually a Windows-only fork but got at least mostly merged into this version somewhere along the way.

(In fact, I think that's the fork archived here in the legacy-win32 branch.)

@Menshin
Copy link

Menshin commented Nov 20, 2024

Hey everyone.

That's quite a ping from the past you just send ...

Chokboyz was actually my (youngster) nickname on the Spiderweb forum and i took the Win32 version coding from where Ormus left it after he had no more time to work on it.
I ultimately produced the 1.2.0a binaries at https://openboe.com/oldbuilds/ iirc, but i don't recall having uploaded more than an archive back then.

It was mostly bug fixes and code cleaning/feature readding and i distinctly remember having several posts exchanges with Celtic Minstrel and others involved in the niche open BoE coding/scenario making scene.

Glad to see people still working on this !
I've been, on my part, working on and off (time is hard to come by) on trying to convert Exile 1 to a BoE scenario (deassembling the exec).

No problem if you want to add me as Menshin in the credits but that's up to you (i've not contributed to anything since the Google Code => GitHub switch).

@catphive
Copy link
Member

That's a cool project.

It would be amazing if the original Exile 1,2,3 could run on modern platforms... especially with the music that some versions of exile had.

@Menshin
Copy link

Menshin commented Nov 20, 2024

There's some subtle (and not so subtle) differences between Win and Mac versions, but the idea is in fact to make them run on modern platforms.

I didn't know there was some music with Exile 1-2-3. Would be great if i could find these and readd them indeed !

Edit : found the tracker files, seems like Jeff sneaked some 90's Dune OST in his game 👀

@NQNStudios
Copy link
Collaborator Author

NQNStudios commented Nov 22, 2024

Missing from your list is *i (Stareye).

To credit *i I'll have to draw an asterisk for the bitmap font 😆

He responded to one of my recent forum posts so I'll try sending a PM to ask what name he wants in there. (Without biasing him away from the one that requires more work.)

@CelticMinstrel
Copy link
Member

CelticMinstrel commented Nov 24, 2024

I've been, on my part, working on and off (time is hard to come by) on trying to convert Exile 1 to a BoE scenario

Ah, this sounds cool! It's very, very, very low on my priority list, especially since I'm not even sure if it's "allowed", but I'd really be interested in someday having BoE scenarios for Escape from the Pit, Crystal Souls, and Ruined World.

There are likely a handful of special mechanics in those that would require new features in the engine though. For example, the slime pits couldn't have been done in the original editor, though the OBoE version should be able to implement them. I think even Exile 1 and 2 probably have a few things like that. And then there's the template town system from Exile 3…

@Menshin
Copy link

Menshin commented Nov 24, 2024

Ah, this sounds cool! It's very, very, very low on my priority list, especially since I'm not even sure if it's "allowed"

If it gets to the point it looks doable, I'll get permission from Jeff of course.

There are likely a handful of special mechanics in those that would require new features in the engine though.

True for Exile 2 and 3 but if i remember correctly Exile 1 doesn't have specials that couldn't be done in the BoE editor (and i was surprised to never have noticed there was no item in towns/dungeons outside of chests).

We'll see what is needed along the way.
Exile 3 templates are a given though ; iirc we had somebody working on the mechanism back then (Ishad Nha or something ?)

For example, the slime pits couldn't have been done in the original editor

Funnily, i remember these still being hardcoded (animation and all) in the Windows version of the BoE code and could be randomly triggered with a fireball in the right town at the right coordinates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Related to the build system or other things other than the code work Non coding related task
Projects
None yet
Development

No branches or pull requests

7 participants