Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for full-screen dialogs #3575

Open
fabriziocucci opened this issue Jan 5, 2023 · 2 comments
Open

Add support for full-screen dialogs #3575

fabriziocucci opened this issue Jan 5, 2023 · 2 comments

Comments

@fabriziocucci
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Not sure if I've missed it but, it seems full-screen dialog are currently not supported.

Describe the solution you'd like
It would be great to support full-screen dialogs as per MD3 spec.

Describe alternatives you've considered
Tried to customise the existing Dialog to work full-screen dialog with messy results.

Additional context
Screenshot 2023-01-05 at 18 04 30

@fabriziocucci fabriziocucci changed the title Add support for full-screen dialog Add support for full-screen dialogs Jan 5, 2023
@fabriziocucci
Copy link
Contributor Author

For the people landing on this feature request, while this is is being worked on, you can temporarily build a full-screen dialog by mixing and matching some of the existing components:

import { Modal } from "react-native";
import { Appbar, Button, Dialog } from "react-native-paper";

<Modal animationType="..." onRequestClose={dismiss} presentationStyle="overFullScreen" visible={...}>
    <Appbar.Header>
        <Appbar.Action icon="close" onPress={dismiss} />
        <Appbar.Content title="New event" />
        <Button onPress={save}>Save</Button>
    </Appbar.Header>
    <Dialog.Content>
        /* dialog content */
    </Dialog.Content>
</Modal>

NOTE: you could also use the Modal from react-native-paper but then you wouldn't be able to customise the animationType in case, for instance, you need a slide animation.

Really looking forward to get rid of this hack! :)

@sangamesh1439
Copy link
Contributor

@lukewalczak Can I pick this up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants