Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React-navigation presentation: modal inner Component shift #3059

Open
midrizi opened this issue Jan 29, 2022 · 3 comments
Open

React-navigation presentation: modal inner Component shift #3059

midrizi opened this issue Jan 29, 2022 · 3 comments

Comments

@midrizi
Copy link

midrizi commented Jan 29, 2022

Current behaviour

I noticed this using <Menu>, when menu is visible it is like 8~10px below where it should be, this seems to be the case with all Components inside react-navigation presentation: modal on iOS.

Expected behaviour

Components to be where they are on the screen, if you try to use the onLayout you will get wrong position of the element

Code sample

https://snack.expo.dev/9cdSNjwzL

Screenshots (if applicable)

Presentation modal Normal page

What have you tried

This is what I mean by shift:

Your Environment

software version
ios or android 15.2
react-native 0.64.3
react-native-paper 4.9.2
node v12.22.7
npm or yarn yarn
expo sdk 5.0.3
@github-actions
Copy link

Couldn't find version numbers for the following packages in the issue:

  • react-native-vector-icons
  • npm
  • yarn
  • expo

Can you update the issue to include version numbers for those packages? The version numbers must match the format 1.2.3.

The versions mentioned in the issue for the following packages differ from the latest versions on npm:

  • react-native (found: 0.64.3, latest: 0.67.1)
  • react-native-paper (found: 4.9.2, latest: 4.11.2)

Can you verify that the issue still exists after upgrading to the latest versions of these packages?

@midrizi midrizi changed the title react-navigation Modal inner Component shift React-navigation presentation: modal inner Component shift Jan 29, 2022
@MathisBarre
Copy link

Same issue here, i guess i will add an hard-coded transform to fix it. Not ideal

@alesdvorakcz
Copy link

Same issue here. Even bigger problem is with presentation: formsheet on ipads

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants