Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies for mid-2021 #188

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update dependencies for mid-2021 #188

wants to merge 2 commits into from

Conversation

MichaelTamaki
Copy link
Collaborator

Description

Fixes issue #187

Updates dependencies in package.json and package-lock.json. Bump NodeJS version in Github Actions to 14 from 12.

Reviewers: Please pull this branch, run npm ci, and verify that everything works locally!

Pre-PR checklist

  • Ran npm run serve and:
    • Checked basic functionality
    • Checked that errors are handled
  • Ran npm run lint
  • Ran npm run test:unit
  • Ran npm run test:e2e and ran relevant tests
  • Attached reviewers to PR and pinged on Slack/email

adhamrait
adhamrait approved these changes Jul 18, 2021
View reviewed changes
Copy link
Collaborator

@adhamrait adhamrait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

vhlee7
vhlee7 approved these changes Jul 19, 2021
View reviewed changes
Copy link
Contributor

@vhlee7 vhlee7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm on mac and it works for me.

samuel-stahl
samuel-stahl approved these changes Jul 20, 2021
View reviewed changes
Copy link
Contributor

@samuel-stahl samuel-stahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good on Windows, approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vhlee7 vhlee7 vhlee7 approved these changes

@adhamrait adhamrait adhamrait approved these changes

@samuel-stahl samuel-stahl samuel-stahl approved these changes

@rmpowell77 rmpowell77 Awaiting requested review from rmpowell77

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MichaelTamaki @samuel-stahl @adhamrait @vhlee7