Basic flow editor and connect dots tool #179
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adhamrait
approved these changes
Jun 28, 2021
| <style scoped lang="scss"> | ||
| .grapher--flow-line { | ||
| fill: none; | ||
| stroke: $founders-rock; |
| @@ -0,0 +1,39 @@ | |||
| <template> | |||
| <div> | |||
| <b-field label="View Mode"> | |||
There was a problem hiding this comment.
What if we put "View Mode" under the view menu bar?
| super(); | ||
| GlobalStore.commit(Mutations.CLEAR_SELECTED_DOTS); | ||
| this.openToast( | ||
| "Connect Dots tool activated. Select a dot from the current stuntsheet." |
There was a problem hiding this comment.
These helpful hints are really cool
| return this.$props.isConnected | ||
| ? nextSSDotAppearance | ||
| : nextSSUnconnectedDotAppearance; | ||
| } |
There was a problem hiding this comment.
Maybe we should have the appearance of the connected dots mimic the starting dot's appearance? It might make situations like this where multiple different dot types have paths that overlap a bit clearer:
There was a problem hiding this comment.
Good idea... Let's re-visit this once we get this in the hands of STUNT.
This was referenced Jul 10, 2021
Open
|
Following our discussion in the mtg today, we'll be breaking this PR up into smaller issues:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue #96
Basic flow editor and connect dots tool
Pre-PR checklist
npm run serveand:npm run lintnpm run test:unitnpm run test:e2eand ran relevant testsScreenshots/GIFs
Original state: 2 dots, with 2 stuntsheets
After clicking the "Connect Dots" tool, it changes to "Flow" View Mode and shows a toast at the top of the screen with directions
Selecting a dot from the current stuntsheet
Selecting a dot from the next stuntsheet
Changing the tool to Box Select, and selecting the dot to see the new flow
A fun continuity!