Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot save EligibilityVerifier without providing an AuthProvider #1977

Closed
angela-tran opened this issue Mar 22, 2024 · 1 comment · Fixed by #1979
Closed

Cannot save EligibilityVerifier without providing an AuthProvider #1977

angela-tran opened this issue Mar 22, 2024 · 1 comment · Fixed by #1979
Assignees
Labels
bug Something isn't working

Comments

@angela-tran
Copy link
Member

(Prompted by post-merge steps for #1970)

Intended behavior is that an EligibilityVerifier can exist without an AuthProvider. However, currently it is not possible to save one in that state from the admin interface.

The reason why we have existing EligibilityVerifiers with no auth_provider is because they were created externally rather than through the admin interface (see #1856 for notes on that process).

To Reproduce

Steps to reproduce the behavior:

  1. Go to /admin
  2. Log in
  3. Click on "Eligibility verifiers"
  4. Choose an eligibility verifier that does not have an auth provider
  5. Go into the form for editing it
  6. Update some field (e.g. Name)
  7. Click "Save"
  8. Notice error saying the Auth provider field is required

Expected behavior

The eligibility verifier is saved with the update you made.

Screenshots

Expand to see

image

Additional context

Whether as a part of this issue or a separate one, we should go through and make sure all our model fields work as intended from the admin interface.

@angela-tran angela-tran added the bug Something isn't working label Mar 22, 2024
This was referenced Mar 22, 2024
@angela-tran angela-tran moved this from Todo to In Progress in Digital Services Mar 22, 2024
@angela-tran angela-tran self-assigned this Mar 22, 2024
@thekaveman thekaveman moved this from In Progress to In Review in Digital Services Mar 22, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Digital Services Mar 25, 2024
@angela-tran
Copy link
Member Author

I was able to save a verifier without needing to have an auth provider 🎉

This allowed me to set help_template for MST and SBMTD agency card flows on dev, which finishes out the post-merge steps from #1970 ✔️

Whether as a part of this issue or a separate one, we should go through and make sure all our model fields work as intended from the admin interface.

Done for all model fields

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant